search

GenieFramework / StippleUI.jl

StippleUI is a library of reactive UI elements for Stipple.jl.
MIT License
84 stars 15 forks source link

fix upload path in windows #127

Closed hhaensel closed 8 months ago

hhaensel commented 8 months ago

Currently uf.tmppath is wrongly transmitted during broadcast in windows due to backslashes.

This PR fixes the coding by making use of js_attr.

@essenciary , @PGimenez May I raise the question, why the channel is broadcasted? The channel is stored within the model anyhow. Maybe we should remove that within this PR?

alfa33333 commented 8 months ago

Just today started writing an app in windows and found this problem exactly!

essenciary commented 8 months ago

@essenciary , @PGimenez May I raise the question, why the channel is broadcasted? The channel is stored within the model anyhow. Maybe we should remove that within this PR?

When the file is processed on the server side we have no access to the model to trigger the handlers. So the workaround was to push an update to the user on the front, using the channel, so that the frontend triggers the handlers. Not ideal but I couldn't find a better solution.