search

GenieFramework / StippleUI.jl

StippleUI is a library of reactive UI elements for Stipple.jl.
MIT License
84 stars 15 forks source link

click not adding modifiers properly #86

Closed AbhimanyuAryan closed 1 year ago

AbhimanyuAryan commented 1 year ago

this pr solves issue of modifier not being appended in else case

and modifier chaining

<a v-on:click.stop.prevent="doThat"></a>
AbhimanyuAryan commented 1 year ago

@hhaensel would you be kind enough to review this and merge :)

Screenshot 2023-01-21 at 5 53 19 PM
AbhimanyuAryan commented 1 year ago

@hhaensel I think you missed this notification. Can you please review this PR so I can merge it?

hhaensel commented 1 year ago

Sorry, I really missed this one. I made slight changes to support both String/Symbol and Vector of String/Symbol syntax.

hhaensel commented 1 year ago

We will touch this once more, if we should agree on keyword argument syntax of the macro as described in https://github.com/GenieFramework/Stipple.jl/issues/172

AbhimanyuAryan commented 1 year ago

We will touch this once more, if we should agree on keyword argument syntax of the macro as described in GenieFramework/Stipple.jl#172

sure

hhaensel commented 1 year ago

Feel free to merge.

P.S: What do you think about the kw syntax?

AbhimanyuAryan commented 1 year ago

Feel free to merge.

P.S: What do you think about the kw syntax?

I think that is really nice and solves the problem to expr going in content. I have also faced this issue previously. So does this mean we need to do changes in all macros @iif @els etc?

hhaensel commented 1 year ago

Exactly. I already started building such macros exemplarily and it would not be a very demanding work. I'll give it a go then.

AbhimanyuAryan commented 1 year ago

@hhaensel maybe you can push some and I can contribute to same branch?

hhaensel commented 1 year ago

I already pushed to hh-kw-macros. It's almost done. Some changes have to be pushed to StippleUI that are dependent...

hhaensel commented 1 year ago

Please check out hh-kw-macros in both Stipple and StippleUI. I moved @click from StippleUI to Stipple.Elements. I think it's all ready now. Next StippleUI version needs to compat the respective Stipple version...

AbhimanyuAryan commented 1 year ago

thanks @hhaensel