Genio-The-Haiku-IDE / Genio

The Haiku IDE
Other
69 stars 9 forks source link

Settings: Add info about global settings without .editorconfig #382

Closed humdingerb closed 4 months ago

humdingerb commented 5 months ago
humdingerb commented 5 months ago

I don't know if this is acceptable. I just added the no-editorconfig-used info to the setting "Ignore .editorconfig" as the text will appear after it. Modelled after LSP's "This setting will be updated on restart."

Sure would be nicer if there were a dedicated "just-info-no-actual-config". Possibly with that attention-grabbing horizontal separator line...

jackburton79 commented 4 months ago

We would have to implement GSettings/ConfigWindow to do something like this. Maybe @Freaxed has any idea about?

Freaxed commented 4 months ago

I found a way to add 'separator' element in the config. The point is that BSeparatorView sacrifices the line space in favour of text and the ending result is not really satisfying.. (see picture) screenshot44

Not sure if there is a way to force the BSeparationView to keep a minimun line space on the borders...

humdingerb commented 4 months ago

Can you use ExplicitMinSize() with the string's length + 20 on the thing?

Freaxed commented 4 months ago

Good suggestion! screenshot45

Freaxed commented 4 months ago

I created a new PR for ConfigSeparator feature. (#391). Let's wait for it to be approved before merging/rebasing this.

jackburton79 commented 4 months ago

You can merge this after the other one.

humdingerb commented 4 months ago

I rebase after the config separator change was merged and updted the commit message. It's now just the move of the editor zoom setting into "Visuals". Should be ready to merge.