search

GeniusVentures / AsyncIOManager

Parsing and loading any format file support by MNN library
0 stars 0 forks source link

Update MNNLoader to generic #5

Closed scorpioluck20 closed 3 months ago

scorpioluck20 commented 1 year ago

MNNLoader should be MNNSaver, not Loader. See other comments

Hi @Super-Genius We should create MNNSaver for save action. If we rename MNNLoader to MNNSaver, I think we should delete IPFSLoader too. We should have CommonLoader for almost of type prefix. CommonLoader will load all contents to the buffer, and FileParser/FileSaver will be working on this buffer. The special prefix loader (Need extra action in the loading step), will be defined and registered after. What's do you thing?

scorpioluck20 commented 1 year ago

Hi @Super-Genius , I suggest merging this PR and close #1 . Then we can continue with Async Loader/Parsing/Saving task in #3 What do you think?