search

Genivia / ugrep

NEW ugrep 6.5: a more powerful, ultra fast, user-friendly, compatible grep. Includes a TUI, Google-like Boolean search with AND/OR/NOT, fuzzy search, hexdumps, searches (nested) archives (zip, 7z, tar, pax, cpio), compressed files (gz, Z, bz2, lzma, xz, lz4, zstd, brotli), pdfs, docs, and more
https://ugrep.com
BSD 3-Clause "New" or "Revised" License
2.57k stars 109 forks source link

Fix installation target to use DESTDIR when setting up completions #336

Closed alerque closed 8 months ago

alerque commented 8 months ago

Fixes #335

This is a minimal fix, there are a few other issues with this makefile arrangement, but this should be the most basic broken bit

alerque commented 8 months ago

As a test case I've used this PR as a patch and applied it against Arch Linux packaging to sucessfully update the packages there.

https://gitlab.archlinux.org/archlinux/packaging/packages/ugrep/-/commit/c57a8976880b65bd91f1141deff36fdf05a6895a#9b9baac1eb9b72790eef5540a1685306fc43fd6c_27_33

genivia-inc commented 8 months ago

Thank you for your quick feedback! I will take a closer look today to merge and fix the problem. I understand the DESTDIR problem for package distributors, which I had overlooked. I did my best to follow the (somewhat scarce) information I could find on defining the configure scripts and Makefile.am to install completions.

alerque commented 8 months ago

I did my best to follow the (somewhat scarce) information I could find on defining the configure scripts and Makefile.am to install completions.

True story, the docs and even sane examples in the wild are a bit scarce. You did a better job than many projects at their first attempt at allowing configurable completion installation!

genivia-inc commented 8 months ago

Should be fixed now in v4.4.1.