search

Genometric / MSPC

Using combined evidence from replicates to evaluate ChIP-seq peaks
https://genometric.github.io/MSPC/
GNU General Public License v3.0
19 stars 10 forks source link

Fix a bug reporting incorrect number of consensus peaks on the terminal #181

Closed VJalili closed 1 year ago

VJalili commented 1 year ago

This PR fixes a bug where MSPC is not reporting a correct number of the identified consensus peaks on the terminal. The issue is related to the recently added stranded analysis (https://github.com/Genometric/MSPC/pull/176), where MSPC wrote in the terminal the number of strands instead of the peak count for consensus peaks.

This PR adds a unit test to reproduce the issue and fixes the bug.

Thanks to @MeriemBahda for reporting this bug!

codecov[bot] commented 1 year ago

Codecov Report

Merging #181 (502262f) into dev (1fb64b7) will not change coverage. The diff coverage is n/a.

:exclamation: Current head 502262f differs from pull request most recent head 0ed52a1. Consider uploading reports for the commit 0ed52a1 to get more accurate results

@@           Coverage Diff           @@
##              dev     #181   +/-   ##
=======================================
  Coverage   97.52%   97.52%           
=======================================
  Files          43       43           
  Lines        2178     2178           
=======================================
  Hits         2124     2124           
  Misses         10       10           
  Partials       44       44

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more