search

GenomicDataInfrastructure / gdi-userportal-ckan-docker

Scripts and images to run CKAN using Docker Compose
0 stars 2 forks source link

chore(deps): update dependencies and settings for CKAN 2.11 compatibility #123

Closed Markus92 closed 6 days ago

Markus92 commented 2 months ago

New DCAT extension is required

New harvest extension is necessary. There is no release yet (latest release is June '23), so tagged the latest current commit in master branch

recline_view plugin is unsupported in 2.11, so replaced with datatables_view

Due to being debian-based, using apt-get to install dependencies. supervisor is done in base image, we need to add postgres client for loading the translations table. cron is not installed by default and I cannot test atm how well it'll work.

Some more changes might be necessary, but a first smoketest with this seems to work.

Summary by Sourcery

Update dependencies and settings for CKAN 2.11 compatibility, including changing the base image, replacing unsupported plugins, and adjusting service configurations in docker-compose.

Build:

Deployment:

Chores:

Markus92 commented 2 months ago

Fixed the issues. I'd still advise waiting for merging this in until ckanext-dcat 2.0 scheming and changes are prepared.

sonarcloud[bot] commented 2 months ago

Quality Gate Passed Quality Gate passed

Issues
3 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

brunopacheco1 commented 1 week ago

Hey @Markus92 , just to let you know the new harvest release is out there and our ckan-docker has it installed, and also latest dcat extension, fair-datapoint and scheming changes.

Could you please also pay attention to the impacts on UI? We have made quite a lot of theme changes, that may not work correctly anymore.

Markus92 commented 1 week ago

@hcvdwerf didn't you already take a look at this?

hcvdwerf commented 1 week ago

@hcvdwerf didn't you already take a look at this?

Not yet, but It requires only resolving conflicts and some tests . You are free to go ;-)

sonarcloud[bot] commented 6 days ago

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

sourcery-ai[bot] commented 6 days ago

Reviewer's Guide by Sourcery

This PR updates the CKAN environment to be compatible with version 2.11.0. The changes include updating the base Docker image, modifying plugin configurations, adjusting container ports, and adding necessary system dependencies. The implementation focuses on dependency management and configuration updates while maintaining existing functionality.

No diagrams generated as the changes look simple and do not need a visual representation.

File-Level Changes

Change Details Files
Updated base CKAN version and dependencies
  • Updated base Docker image from 2.10.5 to 2.11.0
  • Removed unsupported recline_view plugin
  • Removed text_view and image_view plugins from configuration
  • Added system dependencies for cron and postgresql-client
 ckan/Dockerfile
Modified container configuration and health checks
  • Changed application port from 5000 to 5500
  • Updated healthcheck URLs to use new port
  • Reformatted healthcheck test commands for consistency
 docker-compose.yml
Improved Docker build configuration
  • Added cache mounts for apt operations
  • Cleaned up formatting and whitespace in Dockerfile
  • Added comments explaining the purpose of system dependencies
 ckan/Dockerfile

Possibly linked issues

Tips and commands #### Interacting with Sourcery - **Trigger a new review:** Comment `@sourcery-ai review` on the pull request. - **Continue discussions:** Reply directly to Sourcery's review comments. - **Generate a GitHub issue from a review comment:** Ask Sourcery to create an issue from a review comment by replying to it. - **Generate a pull request title:** Write `@sourcery-ai` anywhere in the pull request title to generate a title at any time. - **Generate a pull request summary:** Write `@sourcery-ai summary` anywhere in the pull request body to generate a PR summary at any time. You can also use this command to specify where the summary should be inserted. #### Customizing Your Experience Access your [dashboard](https://app.sourcery.ai) to: - Enable or disable review features such as the Sourcery-generated pull request summary, the reviewer's guide, and others. - Change the review language. - Add, remove or edit custom review instructions. - Adjust other review settings. #### Getting Help - [Contact our support team](mailto:support@sourcery.ai) for questions or feedback. - Visit our [documentation](https://docs.sourcery.ai) for detailed guides and information. - Keep in touch with the Sourcery team by following us on [X/Twitter](https://x.com/SourceryAI), [LinkedIn](https://www.linkedin.com/company/sourcery-ai/) or [GitHub](https://github.com/sourcery-ai).