Closed hcvdwerf closed 3 months ago
This pull request implements a new feature to configure catalog harvesting on a per-harvest basis for the FAIR Data Point harvester. The changes include:
ckanext.fairdatapoint.harvest_catalogs
to enable/disable catalog harvesting globally.The implementation focuses on flexibility, allowing users to control catalog harvesting at both the global and per-harvest levels.
Files | Changes |
---|---|
ckanext/fairdatapoint/harvesters/domain/fair_data_point_record_provider.py |
Added a new configuration option harvest_catalogs to FairDataPointRecordProvider |
ckanext/fairdatapoint/harvesters/domain/fair_data_point_record_provider.py |
Modified _process_catalog method to respect the harvest_catalogs setting |
ckanext/fairdatapoint/harvesters/fair_data_point_civity_harvester.py |
Updated FairDataPointCivityHarvester to handle the new harvest_catalogs configuration |
ckanext/fairdatapoint/harvesters/fair_data_point_civity_harvester.py |
Added a new method _get_harvest_catalog_setting to determine the harvest_catalogs value |
ckanext/fairdatapoint/tests/test_record_provider.py ckanext/fairdatapoint/tests/test_fair_data_point_civity_harvester.py |
Added new tests for the harvest_catalogs functionality |
README.md |
Updated README with information about the new ckanext.fairdatapoint.harvest_catalogs configuration option |
@sourcery-ai review
🚀 Pull Request Checklist
Title:
[ ]
A brief, descriptive title for the changes.Description:
[ ]
Provide a clear and concise description of your pull request, including the purpose of the changes and the approach you've taken.Context:
[ ]
Why are these changes necessary? What problem do they solve? Link any related issues.Changes:
[ ]
List the major changes you've made, ideally organized by commit or feature.Testing:
[ ]
Describe how the changes have been tested. Include any relevant details about the testing environment and the test cases.Screenshots (if applicable):
[ ]
If your changes are visual, include screenshots to help explain your changes.Additional Information:
[ ]
Add any other information that might be useful for reviewers, such as considerations, discussions, or dependencies.Checklist:
[ ]
I have checked that my code adheres to the project's style guidelines and that my code is well-commented.[ ]
I have performed self-review of my own code and corrected any misspellings.[ ]
I have made corresponding changes to the documentation (if applicable).[ ]
My changes generate no new warnings or errors.[ ]
I have added tests that prove my fix is effective or that my feature works.[ ]
New and existing unit tests pass locally with my changes.Summary by Sourcery
Add support for configurable catalog harvesting in FairDataPointRecordProvider and update FairDataPointCivityHarvester to utilize this configuration. Enhance logging and update documentation to reflect the new configuration option. Include new unit tests to ensure the feature works as expected.
New Features:
Enhancements:
Documentation:
ckanext.fairdatapoint.harvest_catalogs
configuration setting in the README.md.Tests: