feat(mapping): Update mapping with missing fields after updating to C…

[hcvdwerf]

…KAN DCAT EXTENSION 2.1.0

🚀 Pull Request Checklist

• Title:

  • [ ] Add missing field after upgrade to DCAT extension 2.1.0

• Description:

  • [ ] After upgrading to DCAT CKAN extension 2.1.0 some fields within contact point and publisher/creator where missing. After this merge this fields will be available

• Context:

  • [ ] To be much as possible compliant with DCAT AP 3

• Changes:

  • [ ] Add URI mapping to Agent(publisher/creator) Add identifier to contactpoint

• Testing:

  • [ ]Modified some UT

• Checklist:

  • [ x] I have checked that my code adheres to the project's style guidelines and that my code is well-commented.
  • [ x] I have performed self-review of my own code and corrected any misspellings.
  • [ x] I have made corresponding changes to the documentation (if applicable).
  • [ x] My changes generate no new warnings or errors.
  • [x ] I have added tests that prove my fix is effective or that my feature works.
  • [ x] New and existing unit tests pass locally with my changes.

Summary by Sourcery

Enhance the mapping by adding missing fields 'uri' and 'identifier' to contact points and agents after upgrading to DCAT CKAN extension 2.1.0. Update YAML configurations and modify unit tests to ensure compliance with DCAT AP 3.

New Features:

• Add URI mapping to Agent (publisher/creator) and identifier to contact point to enhance data representation.

Enhancements:

• Update CKAN and discovery YAML files to include new fields 'uri' and 'identifier' for better compliance with DCAT AP 3.

Tests:

• Modify unit tests to accommodate the new fields 'uri' and 'identifier' in contact points and agents.

[sourcery-ai[bot]]

Reviewer's Guide by Sourcery

This PR updates the data model and mapping logic to accommodate new fields introduced in CKAN DCAT Extension 2.1.0. The changes primarily focus on adding URI fields to Agent entities (publisher/creator) and identifier fields to contact points, ensuring better compliance with DCAT AP 3.

ER diagram for updated CKAN data model

erDiagram
    CkanContactPoint {
        string name
        string email
        string uri
        string identifier
    }
    CkanAgent {
        string name
        string email
        string url
        string type
        string uri
    }
    ContactPoint {
        string name
        string email
        string uri
        string identifier
    }
    Agent {
        string name
        string email
        string url
        string type
        string uri
        string identifier
    }

Updated class diagram for CKAN mapping

classDiagram
    class CkanContactPoint {
        +String name
        +String email
        +String uri
        +String identifier
    }
    class CkanAgent {
        +String name
        +String email
        +String url
        +String type
        +String uri
    }
    class ContactPoint {
        +String name
        +String email
        +String uri
        +String identifier
    }
    class Agent {
        +String name
        +String email
        +String url
        +String type
        +String uri
        +String identifier
    }
    CkanContactPoint --> ContactPoint
    CkanAgent --> Agent

File-Level Changes

Change	Details	Files
Added new fields to OpenAPI specifications for ContactPoint and Agent entities	Added 'identifier' field to ContactPoint schema Added 'uri' field to Agent schema	src/main/openapi/ckan.yaml src/main/openapi/discovery.yaml
Updated mapping implementations to handle new fields	Added URI mapping in agent parser Added identifier mapping in contact point conversion	src/main/java/io/github/genomicdatainfrastructure/discovery/datasets/infrastructure/ckan/utils/CkanAgentParser.java src/main/java/io/github/genomicdatainfrastructure/discovery/datasets/infrastructure/ckan/utils/PackageShowMapper.java
Updated unit tests to verify new field mappings	Added test cases for contact point identifier field Added test cases for agent URI field	src/test/java/io/github/genomicdatainfrastructure/discovery/services/PackageShowMapperTest.java

---

Tips and commands

#### Interacting with Sourcery - **Trigger a new review:** Comment `@sourcery-ai review` on the pull request. - **Continue discussions:** Reply directly to Sourcery's review comments. - **Generate a GitHub issue from a review comment:** Ask Sourcery to create an issue from a review comment by replying to it. - **Generate a pull request title:** Write `@sourcery-ai` anywhere in the pull request title to generate a title at any time. - **Generate a pull request summary:** Write `@sourcery-ai summary` anywhere in the pull request body to generate a PR summary at any time. You can also use this command to specify where the summary should be inserted. #### Customizing Your Experience Access your [dashboard](https://app.sourcery.ai) to: - Enable or disable review features such as the Sourcery-generated pull request summary, the reviewer's guide, and others. - Change the review language. - Add, remove or edit custom review instructions. - Adjust other review settings. #### Getting Help - [Contact our support team](mailto:support@sourcery.ai) for questions or feedback. - Visit our [documentation](https://docs.sourcery.ai) for detailed guides and information. - Keep in touch with the Sourcery team by following us on [X/Twitter](https://x.com/SourceryAI), [LinkedIn](https://www.linkedin.com/company/sourcery-ai/) or [GitHub](https://github.com/sourcery-ai).