Closed hcvdwerf closed 2 months ago
This pull request reverts changes related to the sorting of dataset titles in the CKAN query API. The modification of the 'sort' parameter, which previously replaced 'title' with 'title_string', has been removed from both BeaconDatasetsRepository and CkanDatasetsRepository classes. The original 'sort' parameter from the query is now directly passed to the CKAN API without any string manipulation.
Files | Changes |
---|---|
src/main/java/io/github/genomicdatainfrastructure/discovery/repositories/BeaconDatasetsRepository.java src/main/java/io/github/genomicdatainfrastructure/discovery/repositories/CkanDatasetsRepository.java |
Removed the logic that modified the 'sort' parameter by replacing 'title' with 'title_string' |
src/main/java/io/github/genomicdatainfrastructure/discovery/repositories/BeaconDatasetsRepository.java src/main/java/io/github/genomicdatainfrastructure/discovery/repositories/CkanDatasetsRepository.java |
Simplified the call to ckanQueryApi.packageSearch() by directly passing query.getSort() instead of the modified sortString |
src/main/java/io/github/genomicdatainfrastructure/discovery/repositories/BeaconDatasetsRepository.java src/main/java/io/github/genomicdatainfrastructure/discovery/repositories/CkanDatasetsRepository.java |
Removed the local variable 'sortString' and associated null checks |
🚀 Pull Request Checklist
Title:
[ ]
A brief, descriptive title for the changes.Description:
[ ]
Provide a clear and concise description of your pull request, including the purpose of the changes and the approach you've taken.Context:
[ ]
Why are these changes necessary? What problem do they solve? Link any related issues.Changes:
[ ]
List the major changes you've made, ideally organized by commit or feature.Testing:
[ ]
Describe how the changes have been tested. Include any relevant details about the testing environment and the test cases.Screenshots (if applicable):
[ ]
If your changes are visual, include screenshots to help explain your changes.Additional Information:
[ ]
Add any other information that might be useful for reviewers, such as considerations, discussions, or dependencies.Checklist:
[ ]
I have checked that my code adheres to the project's style guidelines and that my code is well-commented.[ ]
I have performed self-review of my own code and corrected any misspellings.[ ]
I have made corresponding changes to the documentation (if applicable).[ ]
My changes generate no new warnings or errors.[ ]
I have added tests that prove my fix is effective or that my feature works.[ ]
New and existing unit tests pass locally with my changes.Summary by Sourcery
Revert changes to the sort string handling in dataset search queries to fix sorting issues.
Bug Fixes: