GenomicMedLab / cool-seq-tool

https://coolseqtool.readthedocs.io
MIT License
4 stars 0 forks source link

Resolve S608 errors #269

Open korikuzma opened 9 months ago

korikuzma commented 9 months ago

https://docs.astral.sh/ruff/rules/hardcoded-sql-expression/

github-actions[bot] commented 5 months ago

This issue is stale because it has been open 45 days with no activity. Please make a comment for triaging or closing the issue.

jsstevenson commented 4 months ago

I forgot to add this here, but the biggest cause of these violations is the schema variable. I think we should either

a) hard code it -- because theoretically, the rest of the query might be invalid under a different schema anyway, or

b) maybe can use this to set the schema in advance? https://www.postgresql.org/docs/current/ddl-schemas.html#DDL-SCHEMAS-PATH