GenomicMedLab / cool-seq-tool

https://coolseqtool.readthedocs.io
MIT License
4 stars 0 forks source link

Don't download resource files on import #284

Closed jsstevenson closed 2 months ago

jsstevenson commented 4 months ago

The externally-acquired data files are currently downloaded when you import Cool-Seq-Tool. This is sort of weird behavior by itself but also can cause confusing errors if e.g. the FTP connection decides to be slow. It'd be better to acquire these resources lazily or at least when the consuming classes are created.

jsstevenson commented 4 months ago

It also means that you can't import anything unless you have a working internet connection, which isn't ideal - there should be a way to create classes without acquiring new data if existing data is available

korikuzma commented 4 months ago

It also means that you can't import anything unless you have a working internet connection, which isn't ideal - there should be a way to create classes without acquiring new data if existing data is available

Agree, not ideal. I had thought we allowed local data to be used if env vars were set, but it's been a while since I look at cool seq tool

jsstevenson commented 4 months ago

Oh @korikuzma that's probably true -- I'll double check that this is made explicit in the docs