GenomicMedLab / dgipy

Python client for fast access to the Drug-Gene Interaction Database (DGIDb)
MIT License
0 stars 0 forks source link

Use `optional`/`union` instead of the pipe symbol for backwards compatiblity #25

Closed jsstevenson closed 5 months ago

jsstevenson commented 6 months ago

Type annotation is annoying to write but super useful, and the bar character is a great way to represent union types. However, it was introduced in 3.10, and we probably need to retain backwards compatibility with at least 3.9 for another couple years (see https://devguide.python.org/versions/). Thus, we should unfortunately go back and revert these annotations to their optional/union equivalents.

jsstevenson commented 5 months ago

Oops closed in #33