GenomicsStandardsConsortium / mixs

Minimum Information about any (X) Sequence” (MIxS) specification
https://w3id.org/mixs
Creative Commons Zero v1.0 Universal
38 stars 21 forks source link

Term request: Zinc in soil package #105

Open StantonMartin opened 3 years ago

StantonMartin commented 3 years ago

same format as elements in misc and sediment packages

New term details For us to assess a new term request we require the following details:

Term name - 
Structured comment name - [a less than 20char no spaces version of the name]
Definition - [a clear and concise description of the term including ]
Expected value - [e.g. text or EFO and/or OBI etc...]
Value syntax - [e.g. {float} {unit}|{termLabel} {[termID]}|{text}|{timestamp} etc...]
Example - [provide and example value]
Preferred unit - [if appropriate]
Package(s) - [list any packages that should include the new term]

Additional context Add any other context about the new term here.

only1chunts commented 3 years ago
Term name - Zinc
Structured comment name - zinc_conc
Definition - Concentration of zinc in the sample
Expected value - measurement value
Value syntax - {float} {unit}
Example - ?
Preferred unit - ?
Package(s) -hydrocarbon resources-cores, hydrocarbon resources-fluids/swabs, microbial mat/biofilm, sediment, water, soil

@StantonMartin please can you check the above and provide an Example, and the Preferred unit ?

the GSC CIG will then discuss the term and decide if it should be added to the next release. The time scale for this is likely to slow for your use-case (this is something else we are looking at streamlining), but for immediate use you may wish to consider using the term "misc_param"

StantonMartin commented 3 years ago

Hi Chris,

Sorry I have not updated this. Regarding your example, here it is with the parameters filled in:

Term name - Zinc Structured comment name - zinc_conc Definition - Concentration of zinc in the sample Expected value - measurement value Value syntax - 27.3 mg/kg Example - Preferred unit - mg/kg Package(s) -hydrocarbon resources-cores, hydrocarbon resources-fluids/swabs, microbial mat/biofilm, sediment, water, soil

However, thinking through this carefully, I am wondering if this is the smartest way to do this... Every element on earth could potentially end up as a measured value, so why not list add a general term called Element to the standard. It could be something like:

Term name - Element Structured comment name - element Definition - An element found in the periodic table Expected value - May be a long name with first level capitalized, or the periodic table two letter abbreviation ( eg Zinc or ZN) Value syntax - {value}{unit} Example - 27.3 mg/kg Preferred unit - mg/kg (may also take ppm) Package(s) -hydrocarbon resources-cores, hydrocarbon resources-fluids/swabs, microbial mat/biofilm, sediment, water, soil

Another closely related term may be ion which would be the same as element but would be refer to the ion.

See: https://www.ebi.ac.uk/chebi/searchId.do?chebiId=CHEBI:29105 and https://www.ebi.ac.uk/chebi/searchId.do?chebiId=CHEBI:27363

we may also want to include a way to designate the isotope number to distinguish, for instance between Carbon 12, Carbon 13, and Carbon 14.