GenomicsStandardsConsortium / mixs

Minimum Information about any (X) Sequence” (MIxS) specification
https://w3id.org/mixs
Creative Commons Zero v1.0 Universal
38 stars 21 forks source link

bad 'air particulate matter concentration' in addition to valid 'air_PM_concen' #397

Closed turbomam closed 5 months ago

turbomam commented 2 years ago

'air particulate matter concentration' is the title for slot air_PM_concen

unfortunately, somehow a slot with name air particulate matter concentration was also created

I think spaces are illegal in LinkML slot names. It's also a lot longer than 20 characters.

lschriml commented 2 years ago

Hello Mark, email Ramona, Chris and I if there is an urgent issue. There is no character limit for labels, only for structured comment names

Cheers, Lynn

only1chunts commented 2 years ago

The odd thing about those two different "slots" is that they both have the exact same ID value "MIXS:0000108" Not being a LinkML expert I dont know how the unique feature of the MIXS ID value has been allowed to be used twice, surely that shouldn't be possible? The version that appears in the "food-farm environment" package is the correct version. The one that appears in the "air" package has the "Structured comment name" and the "Package item" name reversed somehow.

only1chunts commented 1 year ago

Similar to the issue in #394 this is a problem created by mistake at some point by swapping the short name and label in one of the packages.

Proposal

MIXSID:0000108 in the "air" package should be corrected to use the same details as the "food-farm environment" package

only1chunts commented 5 months ago

The correct details for MIXS:0000108 are:

name: air_PM_concen
annotations:
  Expected_value:
    tag: Expected_value
    value: particulate matter name;measurement value
description: Concentration of substances that remain suspended in the air, and comprise
  mixtures of organic and inorganic substances (PM10 and PM2.5); can report multiple
  PM's by entering numeric values preceded by name of PM
title: air particulate matter concentration
examples:
- value: PM2.5;10 microgram per cubic meter
from_schema: https://w3id.org/mixs
keywords:
- air
- concentration
- particle
- particulate
string_serialization: '{text};{float} {unit}'
slot_uri: MIXS:0000108
multivalued: true
alias: air_PM_concen
domain_of:
- Air
- FoodFarmEnvironment
range: string

The above details are correct in the current main branch. Therefore I am closing this ticket as done.