GenomicsStandardsConsortium / mixs

Minimum Information about any (X) Sequence” (MIxS) specification
https://w3id.org/mixs
Creative Commons Zero v1.0 Universal
36 stars 21 forks source link

Environmental triad terms: multivalued or not? consistency? core and package? #470

Open turbomam opened 2 years ago

turbomam commented 2 years ago

Occurrence says '1' for all of them, but there are multi-valued examples

Annotating a pooled sample taken from various vegetation layers in a forest consider: canopy [ENVO:00000047]|herb and fern layer [ENVO:01000337]|litter layer [ENVO:01000338]|understory [01000335]|shrub layer [ENVO:01000336].

In fact, the schemsheets parser will parse that example into several separate examples, based on the pipe separator.

There shouldn't be any commentary in the Examples. I understand the the addition content could be very helpful. LinkML has other term metadata fields that can capture this, like comments or notes

All examples should be easily machine validate-able against the corresponding Value syntax

In harmonizing between the core and packages sheets, I probably overwrote any custom per-package Examples (in the NMDC copy of the sheets). Possibly Requirement and Preferred unit too. Should retrieve those from the GSC original.

turbomam commented 2 years ago

Their Descriptions and Expected values were inconsistent. I set them all to majority rule, but maybe some of the minority values were better?

turbomam commented 2 years ago

These also appear in the core sheet. All of this should be harmonized, but with some straightforward improvement.

from core

Structured comment name Item (rdfs:label) Definition Expected value Value syntax Example Section Preferred unit Occurrence MIXS ID MIGS ID (mapping to GOLD)
env_broad_scale broad-scale environmental context Report the major environmental system the sample or specimen came from. The system(s) identified should have a coarse spatial grain, to provide the general environmental context of where the sampling was done (e.g. in the desert or a rainforest). We recommend using subclasses of EnvO’s biome class: http://purl.obolibrary.org/obo/ENVO_00000428. EnvO documentation about how to use the field: https://github.com/EnvironmentOntology/envo/wiki/Using-ENVO-with-MIxS The major environment type(s) where the sample was collected. Recommend subclasses of biome [ENVO:00000428]. Multiple terms can be separated by one or more pipes. {termLabel} {[termID]} oceanic epipelagic zone biome [ENVO:01000033] for annotating a water sample from the photic zone in middle of the Atlantic Ocean environment   1 MIXS:0000012  
env_local_scale local environmental context Report the entity or entities which are in the sample or specimen’s local vicinity and which you believe have significant causal influences on your sample or specimen. We recommend using EnvO terms which are of smaller spatial grain than your entry for env_broad_scale. Terms, such as anatomical sites, from other OBO Library ontologies which interoperate with EnvO (e.g. UBERON) are accepted in this field. EnvO documentation about how to use the field: https://github.com/EnvironmentOntology/envo/wiki/Using-ENVO-with-MIxS. Environmental entities having causal influences upon the entity at time of sampling. {termLabel} {[termID]} litter layer [ENVO:01000338]; Annotating a pooled sample taken from various vegetation layers in a forest consider: canopy [ENVO:00000047]|herb and fern layer [ENVO:01000337]|litter layer [ENVO:01000338]|understory [01000335]|shrub layer [ENVO:01000336]. environment   1 MIXS:0000013 MIGS-6 (habitat)
env_medium environmental medium Report the environmental material(s) immediately surrounding the sample or specimen at the time of sampling. We recommend using subclasses of 'environmental material' (http://purl.obolibrary.org/obo/ENVO_00010483). EnvO documentation about how to use the field: https://github.com/EnvironmentOntology/envo/wiki/Using-ENVO-with-MIxS . Terms from other OBO ontologies are permissible as long as they reference mass/volume nouns (e.g. air, water, blood) and not discrete, countable entities (e.g. a tree, a leaf, a table top). The material displaced by the entity at time of sampling. Recommend subclasses of environmental material [ENVO:00010483]. {termLabel} {[termID]} soil [ENVO:00001998]; Annotating a fish swimming in the upper 100 m of the Atlantic Ocean, consider: ocean water [ENVO:00002151]. Example: Annotating a duck on a pond consider: pond water [ENVO:00002228]|air [ENVO_00002005] environment   1 MIXS:0000014