GenomicsStandardsConsortium / mixs

Minimum Information about any (X) Sequence” (MIxS) specification
https://w3id.org/mixs
Creative Commons Zero v1.0 Universal
36 stars 21 forks source link

Lime buffer capacity #525

Open cmungall opened 1 year ago

cmungall commented 1 year ago

I am transferring this request from https://github.com/EnvironmentOntology/envo/issues/1061, I am not the requester.

I have filled in the details to the best of my knowledge based on the references provided.

Term name - Lime buffer capacity Definition - the measure of the amount of soil acidity that must be neutralized to raise soil pH by one unit (source) Expected value - a tuple of a ppm measurement and a time period Example - 1252 ppm; 30m Preferred unit - ppm Package(s) -soil

Additional context Add any other context about the new term here.

Here is a subset of the spreadsheet that needs to be mapped to MIXS:

lime buffer capacity (at 30 minutes) lime buffer capacity (after 5 day incubation)
1252 ppm 3630.8 ppm
1347 ppm 3906.3 ppm
907 ppm 2630.3 ppm
713 ppm 2067.7 ppm
709 ppm 2056.1 ppm
turbomam commented 1 year ago

Thanks, @cmungall. I'm not the original requester either, but I should have made an issue like this long ago.

I would like to raise a question about the structure of the expected tuple. I don't think that LBC is commonly reported over a time course. Rather, it was found that the original 30-minute incubation method did not actually bring the sample to equilibrium, so a new protocol was developed for people who want greater accuracy.

In the NMDC schema, I had modeled this as two slots, lbc30 and lbceq, each of which "expected" a bare float value.

That may not be ideal either, but I did want to start a discussion.

StantonMartin commented 1 year ago

This is accurate. The formal definition of LBC is:

LBC = pHBC (50 mg CaCO3 mmol−1 as indicated in Kissel et. al.

doi:10.2136/sssaj 2011.0091

LBC(30) was used at the University of Georgia for calibration studies, but it should not be confused with LBC. which is something different. The other relevant term (which is not in our dataset but may come into play later) is pHBC as indicated in Bloom, 2000 in https://www.worldcat.org/title/handbook-of-soil-science/oclc/41185186

ramonawalls commented 1 year ago

Our goal is to use terms from domain ontologies to define MIxS terms or their values. Is the request here that we create the new term or is it that we add a MIxS slot that corresponds to an ENVO term? The latter makes more sense to me.

If we are adding a new terms, which packages should it belong to?

We need to discuss how we should handle requests for individual MIxS terms. It is something we have talked about, but not yet implemented.