only1chunts
commented
1 year ago Hi Montana, Good spot on the inconsistencies. I've always treated all 3 of the ENVO terms as multi-valued, whether thats right or wrong I'm now not sure :-D. GigaDB has multiple instances where there are multi-values in both 'env_broad_scale' and 'env_local_scale'. We should ensure that v7 is correct with multi-values allowed. I have added the v7 label so hopefully we'll make sure its done for that release.
Describe the bug A clear and concise description of what the bug is.
'env_local_scale' is described by MIxS as having an occurrence of 1 (multivalue=false). In some env packages (symbiont-associated, food-human foods, food-animal and animal feed, food-food production facility, food-farm environment) have this slot listed separately. There appears to be no variation among what is in base or core MIxS, aside from the examples.
In MIxS, env_local_scale has an example that appears to be multivalue=true, but still has an occurrence of 1.
According to Envo, https://github.com/EnvironmentOntology/envo/wiki/Using-ENVO-with-MIxS , env_local_scale should be allowed to be multivalued = true.
To Reproduce Steps to reproduce the behavior:
Review the Excel export of MIxS v6 & review env_local_scale on the MIxS tab and the environmental_packages tabs.
Expected behavior A clear and concise description of what you expected to happen.
Consistent use of this slot & agreement with ENVO requirments
Additional context Add any other context about the problem here.
The NMDC has had an example of biosamples that would be better fit with multi-valued local scale. To remain consistent with GSC, we have remained single value.