search

GenomicsStandardsConsortium / mixs

Minimum Information about any (X) Sequence” (MIxS) specification
https://w3id.org/mixs
Creative Commons Zero v1.0 Universal
34 stars 20 forks source link

Change enums names to PascalCase not SHOUTINGCASE #627

Closed turbomam closed 3 weeks ago

sujaypatil96 commented 8 months ago

I think this issue can be closed. A fix was made in the schema to change the casing of enum names, and the documentation reflects the same as well: https://genomicsstandardsconsortium.github.io/mixs/enumerations/

mslarae13 commented 1 month ago

@turbomam to double check. Need to run linkML linter & get a report of all elements that don't stick to default rules.

turbomam commented 1 month ago

will run linkml-lint, possibly silencing some rules that we have chosen to ignore

turbomam commented 3 weeks ago

The linkml-lint command has a lot of useful options, but for those who want to keep things simple, it can be run in default mode with make lint which will send a report to the console.

If an enum doesn't have a CamelCase name, it will result in a line like

warning Enum has name 'poorly_NAMED_ENUM' (standard_naming)

so one way to catch enums with non-standard names is

make lint | grep 'Enum has name.*(standard_naming)'

At this time, that command doesn't emit any lines because there aren't any enums with non-standard names