search

GenomicsStandardsConsortium / mixs

Minimum Information about any (X) Sequence” (MIxS) specification
https://w3id.org/mixs
Creative Commons Zero v1.0 Universal
34 stars 20 forks source link

Terms to resolve based on ids #637

Closed sujaypatil96 closed 9 months ago

sujaypatil96 commented 9 months ago

The current deployment of the documentation does not resolve terms based on ids like before. Restore that feature such that the terms resolve based on ids and not their names.

turbomam commented 9 months ago

This task is not complete if only terms resolve by numerical id. See PR notes and links.

turbomam commented 9 months ago
sujaypatil96 commented 9 months ago

@turbomam: currently only term/slot pages can be resolved by id/uri, because only that feature exists (--use-slot-uris) in docgen. I/we can definitely extend docgen to be able to resolve all elements by ids/uris, but that will have a longer turnaround time than 10/19.

turbomam commented 9 months ago

I am not in favor of switching to ID based term resolution except in combination with class resolution by id.

Can you show some evidence that the ID resolution needs to be implemented before October 19th?

sujaypatil96 commented 9 months ago

I dug up this issue: https://github.com/GenomicsStandardsConsortium/mixs/issues/391

It doesn't explicitly say that it needs to be done by 10/19, but it was an issue that @ramonawalls had brought up last year, and we had worked on to get a feature into LinkML docgen to support that.

sujaypatil96 commented 9 months ago

I'm completely okay with whatever we decide, id based resolution or name based resolution (for terms only).

turbomam commented 9 months ago

We agreed to stick with the precedent of id-based term lookup and are working on id-based class lookup too