search

GenomicsStandardsConsortium / mixs

Minimum Information about any (X) Sequence” (MIxS) specification
https://w3id.org/mixs
Creative Commons Zero v1.0 Universal
34 stars 20 forks source link

Term pages should resolve based on ids #638

Closed sujaypatil96 closed 9 months ago

sujaypatil96 commented 9 months ago

Fixes #637

sujaypatil96 commented 9 months ago

Sorry for the preemptive review request. Will open it up for review soon.

turbomam commented 9 months ago

please ensure that all elements are resolved by numerical id. Not just terms. It's possible that we will have to add the class ids, especially the combination class ids

turbomam commented 9 months ago

https://github.com/GenomicsStandardsConsortium/mixs/blob/a8764b785d2a0f7f7de2359e2cd85642285b0ee2/src/mixs/schema/mixs.yaml#L30325C1-L30335C36

turbomam commented 9 months ago
sujaypatil96 commented 9 months ago

Currently, LinkML docgen supports only the resolution of slots/terms by id/slot_uri. To be able to resolve classes (and other LinkML elements like subsets, enums, etc.) by id as well, I can take that upon request and add that feature to the linkml library upstream.

sujaypatil96 commented 9 months ago

Made an issue to document your comment Mark: https://github.com/linkml/linkml/issues/1672

turbomam commented 9 months ago

I support moving forward with this as long as we can keep https://github.com/linkml/linkml/issues/1672 on the fast track