GenomicsStandardsConsortium / mixs

Minimum Information about any (X) Sequence” (MIxS) specification
https://w3id.org/mixs
Creative Commons Zero v1.0 Universal
33 stars 20 forks source link

term total nitrogen concentration (tot_nitro) is water specific, should be general #680

Open mslarae13 opened 8 months ago

mslarae13 commented 8 months ago

Describe the bug A clear and concise description of what the bug is.

The description of tot_nitro is : Total nitrogen concentration of water samples, calculated by: total nitrogen = total dissolved nitrogen + particulate nitrogen. Can also be measured without filtering, reported as nitrogen

The specification of water is limiting, you can have total N on all samples

this is used in extension

To Reproduce Steps to reproduce the behavior:

  1. Go to https://genomicsstandardsconsortium.github.io/mixs/0000102/

Expected behavior A clear and concise description of what you expected to happen.

Terms definitions will be general, not environment specific and slot usage can be added for specific environments

mslarae13 commented 8 months ago

Actually, it looks like a separate slot was made to be less water specific... see https://genomicsstandardsconsortium.github.io/mixs/0000530/

I recommend deprecating tot_nitro and using tot_nitro_content

mslarae13 commented 6 days ago

will complete when deprecation protocol is in place