search

GenomicsStandardsConsortium / mixs

Minimum Information about any (X) Sequence” (MIxS) specification
https://w3id.org/mixs
Creative Commons Zero v1.0 Universal
33 stars 20 forks source link

pcr_cond provides structure and example in description #744

Closed mslarae13 closed 3 weeks ago

mslarae13 commented 6 months ago

Descriptions shouldn't have an example in it.

"Description of reaction conditions and components of PCR in the form of 'initial denaturation:94degC_1.5min; annealing=...'"

recommended change

"Description of reaction conditions and components of polymerase chain reaction performed during library preparation'

only1chunts commented 6 months ago

I'm inclined to not go looking for things like this, but I agree with the principle of removing examples from descriptions when we have to make other updates to a term, or where the example is wrong or misleading. If the TWG want to include this minor update in the next PR/comit thats fine by me (as long as there is an example in the correct linkML field).

mslarae13 commented 5 months ago

@only1chunts I'm happy to work on issues like this.

mslarae13 commented 5 months ago

I would like to ask.. which example is right?

  - value: initial denaturation:94_3;annealing:50_1;elongation:72_1.5;final elongation:72_10;35
  - value: initial denaturation:94degC_1.5min

with our without degC?