New Settings Systems with support for multiple data types.

GentenStudios / Phoenix-OLD

Phoenix is an open world sandbox style voxel game designed to make all content optional.

BSD 3-Clause "New" or "Revised" License

30 stars 10 forks source link

New Settings Systems with support for multiple data types. #331

Closed vyomfadia closed 3 years ago

vyomfadia commented 3 years ago

Resolves: # Authors: @beeperdeeper089

Summary of changes

Allow the settings system to use booleans, strings, and any arithmetic type.
Exit on failure when there is an invalid config file.
Use the config file provided in the CLI arguments.

Caveats

Does this introduce any new bugs?

No more settings in the settings exit menu (will attempt reimplement before merging)
No more settings registration in the Lua modules (will attempt reimplemntation before merging)

On approval

Wait for me.

vyomfadia commented 3 years ago

Had I known Lua only supports doubles....

Regardless, the get method can work just fine without a default parameter - if the value doesn't exist it will default initialize (so most likely, to 0), however getOr implements what you're saying. I may not have that exposed properly to the Lua interface - but I'll take a look and see if I can drop that in easily.

Mac is very... retarded - it's giving me an issue with std::sizet being an unsigned long instead of an unsigned long long --

tobyplowy commented 3 years ago

Build failed. message (3).txt

vyomfadia commented 3 years ago

ci can fuck itself

tobyplowy commented 3 years ago

Still fails to build for me. message (4).txt

tobyplowy commented 3 years ago

Builds but has that crash on startup thing.

tobyplowy commented 3 years ago

Builds and runs. Congrats it was quite the journey.