Feat audio - Githubissues

GentenStudios / Phoenix-OLD

Phoenix is an open world sandbox style voxel game designed to make all content optional.

BSD 3-Clause "New" or "Revised" License

30 stars 10 forks source link

Feat audio #345

Closed apachano closed 3 years ago

apachano commented 3 years ago

Resolves: #327 Authors: @apachano

Summary of changes

Implement Soloud library
Implement Background music
Implement API for registering sounds
Implement API for triggering sounds on block place event
Implement API for triggering sounds on block break event

Caveats

Does this introduce any new bugs?

Until an OSX bug is merged into Soloud's master branch, we are sourcing from a forked version of the repo
Audio isn't 3D yet

On approval

Merge

tobyplowy commented 3 years ago

Mac Ci fails. Always mac for whatever reason.

apachano commented 3 years ago

@tobyplowy The submodule BS is fixed

tobyplowy commented 3 years ago

PR fails to build for me. message.txt

apachano commented 3 years ago

@tobyplowy Can you re-QA to make sure the automatic audiobackend search works. Volume is a touch low on Linux but good enough for now.

tobyplowy commented 3 years ago

How do I test the automatic audio back end search ?

Also PR builds and runs.

apachano commented 3 years ago

All tested lol, I switched the backend in the source so if it runs it's good.

On Sun, Feb 7, 2021, 3:20 PM Toby plowy (Toby109tt) < notifications@github.com> wrote:

How do I test the automatic audio back end search ?

Also PR builds and runs.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/GentenStudios/Phoenix/pull/345#issuecomment-774786983.

vyomfadia commented 3 years ago

I'll run clang-tidy on this and approve once I've done it in the morning

vyomfadia commented 3 years ago

"morning" being completely metaphorical

vyomfadia commented 3 years ago

but, merge conflict so have fun