search

GentenStudios / Phoenix-OLD

Phoenix is an open world sandbox style voxel game designed to make all content optional.
BSD 3-Clause "New" or "Revised" License
30 stars 10 forks source link

Multiple SDL definitions #367

Open JosiahWI opened 3 years ago

JosiahWI commented 3 years ago

Describe the bug

The linker reports duplicate definitions in SDL, and the project fails to link.

To Reproduce

This might not be reproducible on a different OS and setup, but here were my steps.

  1. cmake -S . -B build -DCMAKE_BUILD_TYPE=Release &> log.txt
  2. cmake --build build -j 2 -v &> log.txt
  3. cat log.txt
  4. Observe error.

Expected behavior

I expect the project to compile cleanly with no warnings and errors.

Environment/System (please complete the following information)

Additional context

I have an SDL2 system installation (including development headers), but it should not conflict with this. I suspect something in the CMake config is at fault.

log.txt

JosiahWI commented 3 years ago

I've worked around this by disabling Wayland in SDL2.

vyomfadia commented 3 years ago

Is this a suitable solution or do we need to explore the CMake configuration further?

JosiahWI commented 3 years ago

Disabling Wayland in SDL2 required commenting out the Wayland check in their config. It's not a good solution, but it might not be something we can do anything about on our end.