search

GentenStudios / QuartzEngine

Nolonger used, see Phoenix repo
BSD 3-Clause "New" or "Revised" License
34 stars 10 forks source link

Feat plugin loader #144

Closed SuperFola closed 5 years ago

DontBelieveMe commented 5 years ago

Hey, I've had a quick look over this and just some structural comments, but looks good :+1: - I'll detail on them tomorrow, when I've had a bit more of a think and let my brain rest :sleeping:

apachano commented 5 years ago

@beeperdeeper089 @DontBelieveMe Could either of you look this over and approve this? It's been sitting for a while and I bet Fola would appreciate marking it complete :)

DontBelieveMe commented 5 years ago

Yeah, so I'm on my phone so this isn't going to be the greatest review, but it can at least start the discussion.

One thing I was thinking was that it is cleaner to split the platform dependent code into separate files, which we can then conditionally choose to compile (or not) in CMake. This would get rid of those defines - look up the PIMPL design pattern, that's a good start.

This is a rather big change, so discussing it on discord may be better