Edge stroke gradients and contribution changes

Gentlymad-Studios / GraphViewBase

The base for our NewGraph implementation. Avoids any reliance on the outdated Experimental Graph view form Unity. This is a heavily modified version of: https://github.com/Sahasrara/GraphViewPlayer.

MIT License

16 stars 8 forks source link

Edge stroke gradients and contribution changes #3

Open LacombeJ opened 10 months ago

LacombeJ commented 10 months ago

Hi, I noticed that edge stroke gradients functionality is in the code but is commented out. Is there a reason why?

I have been working on port and edge coloring and found that I've been making some small changes to GraphViewBase to get things working. Is this repo open to submit pull request?

Doppelkeks commented 10 months ago

Uh, good question. If I remember correctly, it was just not needed at the time for NewGraph. I really appreciate any pull request, so send them in and I'll check if the pull request is compatible. :)

LacombeJ commented 10 months ago

@Doppelkeks I submitted a PR. There could be possibly more work to be done since Edge.cs currently resets InputColor and OutputColor on edge selection. In my graph editor I override this to only set EdgeWidth on selected but I didn't touch this since NewGraph styling relies on this.