Closed qbi-geny closed 1 month ago
The status is "draft", but does it still need to be reviewed ?
Yes it is still draft, because so far I haven't managed to validate it works on SaaS.
Finally managed to test it in example web player against staging SaaS ARM when based on https://github.com/Genymobile/genymotion-device-web-player/pull/111
Description
JIRA: SYSTEM-2682
Home widget button is broken on ARM SaaS which uses a PaaS image, as desktop & paas images handle the home button differently.
First, the Android documentation for the actual mapping between linux keyboard keycodes and Android keycodes tells us:
KEY_HOMEPAGE
(Qt::Key_HomePage
) maps to Android KEYCODE_HOME and is the physical home button (back to "desktop")KEY_HOME
(Qt::Key_Home
) maps to Android KEYCODE_MOVE_HOME and isHistorically, it seems that the desktop image maps
KEYCODE_MOVE_HOME
toKEYCODE_HOME
, indevice/genymotion/vbox86/Genymotion_Virtual_Input.kl
, so the SaaS web player mapped the home widget to this button.Now, the PaaS image does not have this mapping (it is not necessary), so the webplayer has an option to translate this button to Meta+Enter, which is a shortcut for the home button.
However, this results in the Paas in Saas configuration being broken, as the SaaS web player sends (ultimately, through webrtcd mapping & redis) the
KEYCODE_MOVE_HOME
to the PaaS image.This fix:
KEY_HOMEPAGE
, as it is more accurate, even though it ends up being translated. We could later remove the translation, when webrtcd is aware of this keycode.Fixes SYSTEM-2682
Type of change
Checklist