Genymobile / genymotion-device-web-player

Genymotion Virtual Device Web Player
https://www.genymotion.com/
MIT License
104 stars 34 forks source link

Always translate home into meta+enter #110

Closed qbi-geny closed 1 month ago

qbi-geny commented 1 month ago

Description

JIRA: SYSTEM-2682

Home widget button is broken on ARM SaaS which uses a PaaS image, as desktop & paas images handle the home button differently.

First, the Android documentation for the actual mapping between linux keyboard keycodes and Android keycodes tells us:

Historically, it seems that the desktop image maps KEYCODE_MOVE_HOME to KEYCODE_HOME, in device/genymotion/vbox86/Genymotion_Virtual_Input.kl, so the SaaS web player mapped the home widget to this button.

Now, the PaaS image does not have this mapping (it is not necessary), so the webplayer has an option to translate this button to Meta+Enter, which is a shortcut for the home button.

However, this results in the Paas in Saas configuration being broken, as the SaaS web player sends (ultimately, through webrtcd mapping & redis) the KEYCODE_MOVE_HOME to the PaaS image.

This fix:

Fixes SYSTEM-2682

Type of change

Checklist

jparez commented 1 month ago

The status is "draft", but does it still need to be reviewed ?

qbi-geny commented 1 month ago

Yes it is still draft, because so far I haven't managed to validate it works on SaaS.

qbi-geny commented 1 month ago

Finally managed to test it in example web player against staging SaaS ARM when based on https://github.com/Genymobile/genymotion-device-web-player/pull/111