Remove Lodash dependency - Githubissues

Genymobile / genymotion-device-web-player

Genymotion Virtual Device Web Player

https://www.genymotion.com/

MIT License

91 stars 31 forks source link

Remove Lodash dependency #58

Closed pgivel closed 7 months ago

pgivel commented 7 months ago

Description

defaultsDeep was causing a weird bug on Shadow's side because of change-in-place behaviour. I found it clearer to use Object.assign from the default library.

Lodash wasn't used anywhere else, so let's remove the dependency.

Notes

Object.assign makes a shallow assignment. I'm in the process of checking if this doesn't break anything.
I would have prefered to use the spread syntax, but it's only available in ES2018 and gulp is holding us back

Type of change

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

[ ] I've read & comply with the contributing guidelines
[ ] I have tested my code for new features & regressions on both mobile & desktop devices, using the latest version of major browsers.
[ ] I have made corresponding changes to the documentation (README.md).
[ ] I've checked my modifications for any breaking changes.

pgivel commented 7 months ago

Closing, as this change isn't actually necessary, the similar change on Shadow's side only was enough.