System 2449/fix gamepad - Githubissues

Genymobile / genymotion-device-web-player

Genymotion Virtual Device Web Player

https://www.genymotion.com/

MIT License

104 stars 34 forks source link

System 2449/fix gamepad #73

Closed cmajed closed 6 months ago

cmajed commented 7 months ago

Description

Rework Gamepad and Gamepad Management to fix:

handle gamepad pugged/unplugged
catch and handle confirmation
send correct vinput gamepad redis message
Handle axis changes
Rework catch and dispatch event to dispatch it only when axes changed
Add vendor id and product id to the plugg in command

Type of change

[ ] Bug fix (non-breaking change which fixes an issue)
[X] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

[ ] I've read & comply with the contributing guidelines
[ ] I have tested my code for new features & regressions on both mobile & desktop devices, using the latest version of major browsers.
[ ] I have made corresponding changes to the documentation (README.md).
[ ] I've checked my modifications for any breaking changes.

pgivel commented 7 months ago

I think the first commit should not be in this PR ? Or maybe this PR should not target main ?

cmajed commented 7 months ago

yes it cames from this PR https://github.com/Genymobile/genymotion-device-web-player/pull/72 I could target it instead!