search

Genymobile / gm_pr

A multi project Github pull request viewer
Apache License 2.0
41 stars 15 forks source link

Speed #61

Closed CedricCabessa closed 9 years ago

CedricCabessa commented 9 years ago

Some nice number in the commit msg of 17583a6

calvarez-ov commented 9 years ago

If I use this conf: LAST_ACTIVITY_FILTER = ("comments", "events", "commits")

Then the page loads with an error, because in practivity.py:get_latest_event(), the variable issue_url is not defined (it's not passed as a parameter).

I'm guessing the same issue exists with get_latest_commit, as pr_url isn't given.

If I use this conf: LAST_ACTIVITY_FILTER = ("comments") then the page loads fine.

CedricCabessa commented 9 years ago

Nobody has time to review/test this. Let's see what happen in prod