Change LGTM column to "Approvals"

Genymobile / gm_pr

A multi project Github pull request viewer

Apache License 2.0

41 stars 15 forks source link

Change LGTM column to "Approvals" #81

Closed qfarizon closed 7 years ago

qfarizon commented 8 years ago

With the new Github PR workflow (https://help.github.com/articles/about-pull-request-reviews/ ) we can now formally approve a PR. gm_pr should take that into account, and count approvals instead of LGTM I propose to count only approvals and drop LGTM parsing completely.

API reference (not yet stable) https://developer.github.com/v3/projects/

calvarez-ov commented 8 years ago

The idea sounds great to me. In our project we don't use the github "review" feature yet (just comments for now), but we don't use LGTM either :)

fbarthelery commented 8 years ago

I looked at the API today and it does not seems to contains anything related to pull request approval. But maybe I did not look right.

CedricCabessa commented 8 years ago

I've contacted github support, they told me it's planned but no ETA. We should watch https://developer.github.com/changes/ for more info (it's in my rss ;-) )

CedricCabessa commented 7 years ago

https://github.com/Genymobile/gm_pr/pull/82