Genymobile / gnirehtet

Gnirehtet provides reverse tethering for Android
Apache License 2.0
6.23k stars 571 forks source link

gnirehtet uses the same port as BOINC (31416) #165

Closed Hyask closed 5 years ago

Hyask commented 5 years ago

I kept having the following issue:

./gnirehtet run
2019-01-18 11:44:38.343 INFO Main: Starting relay server...
2019-01-18 11:44:38.344 INFO Main: Checking gnirehtet client...
2019-01-18 11:44:38.344 ERROR Main: Execution error: IO error: Address already in use (os error 98)

A quick strace shows that gnirehtet tries to bind to port 31416, and a quick netstat shows me that I already have BOINC listening on that port.

I know it's complicated not to conflict with any of the numerous projects in the wild, but I think BOINC is quite an important one, and changing the default port is not that hard, and should have little consequences.

This is also related to #41, since allowing to change the port easily at run time would help in that situation.

I can make a PR if needed (not before February though).

rom1v commented 5 years ago

I know it's complicated not to conflict with any of the numerous projects in the wild

Changing it will probably conflict with something else. 31416 is 10000π. I would like to keep it as the default :)

This is also related to #41, since allowing to change the port easily at run time would help in that situation.

Yes, changing port at runtime would be a good solution.

Hyask commented 5 years ago

Changing it will probably conflict with something else.

Yep, for sure... :/

31416 is 10000π. I would like to keep it as the default :)

Best argument ever :'D ♥

Yes, changing port at runtime would be a good solution.

Then I'll let you handle this problem as itself. I'm closing the issue.