Fixing the issues mentioned by Android Studio

Zero3K commented 7 years ago

Maybe you could fix the ones that are mentioned by it when analyzing the source code.

rom1v commented 7 years ago

Which are?

Zero3K commented 7 years ago

The ones in the html file included in the attached ZIP file.

Inspection Report.zip

ewoks commented 7 years ago

This is getting ridiculous @Zero3K ..

You are free to fork, make corrections, create pull request and any suggestion will be discussed and might be accepted or rejected if not relevant. Opening issues for such a things that you are doing is distracting and contra productive.

If you found some real bug, make new issue. But please stop with writing every single thought or idea, issue with specific app that "works OK on windows" and such that you have. Let's not make it noisy and allow developer to focus on functionalities that app is trying to accomplish.

rom1v commented 7 years ago

@Zero3K gradle build already executes lint and checkstyle.

The rules of Android Studio inspection generate many false positives. That's good to check them once from time to time, just in case, but most of the reports are irrelevant.

I just removed some unnecessary return and added some final, but that's all.

That's great to report issues, but to go in the same direction as @ewoks, you should improve the way to report some of them.

Not:

some application seems slow, here are all the logs, please check

but rather:

I did this, I expected this, I get that. Here are the reasons why this problem does not come from x, y and z, this is why I think this is a bug in gnirehtet

Even reporting code style issues is great, but rather:

I used this tool to analyze the code, those particular points seem relevant, because…

than:

fix all stuff that X tool reports

That way, we could be more efficient ;-)

As far as I remember, this article was great: How to Report Bugs Effectively.

Genymobile / gnirehtet

Fixing the issues mentioned by Android Studio #21