search

Genymobile / scrcpy

Display and control your Android device
Apache License 2.0
111.76k stars 10.7k forks source link

no control command cannot work with turn screen off #1713

Open masterchiang opened 4 years ago

masterchiang commented 4 years ago

--turn-screen-off cannot work together with --no-control ,please fix it

rom1v commented 4 years ago

That's expected: --no-control disables all the controls which could impact the device, and turning the screen off is a control.

$ scrcpy --turn-screen-off --no-control
ERROR: Could not request to turn screen off if control is disabled

Moreover, what would be the usage if you can't control via scrcpy and the screen is off (so you can't control on the device either)?

masterchiang commented 4 years ago

That's expected: --no-control disables all the controls which could impact the device, and turning the screen off is a control.

$ scrcpy --turn-screen-off --no-control
ERROR: Could not request to turn screen off if control is disabled

Moreover, what would be the usage if you can't control via scrcpy and the screen is off (so you can't control on the device either)?

can make this command both working? for example, turn screen off first,second :send no control command

rom1v commented 4 years ago

That makes no sense to me. "No control" means you don't want to control the device. Turning the screen off is controlling the device.

"no control" is not a command to send, it's just a parameter which says to the client to not send any control command (and to the server that it does not even have to listen to control messages).

In practice, why would you want that? If the screen is turned off, you can't control it from the device, and if you can't control it from the computer either, what's the point?

masterchiang commented 4 years ago

That makes no sense to me. "No control" means you don't want to control the device. Turning the screen off is controlling the device.

"no control" is not a command to send, it's just a parameter which says to the client to not send any control command (and to the server that it does not even have to listen to control messages).

In practice, why would you want that? If the screen is turned off, you can't control it from the device, and if you can't control it from the computer either, what's the point?

sure，it use for play pubg mobile，we use other PC software which base on adb control,just a control scene,not contains screen transport,so we need scrcpy as a screen software,and hope the phone screen can close cause screen off could save power and increase game FPS