Genymobile / scrcpy

Display and control your Android device
Apache License 2.0
105.37k stars 10.23k forks source link

--no-audio, error when exit terminal #4975

Open webinizam opened 4 weeks ago

webinizam commented 4 weeks ago

Environment

Describe the bug I use in terminal command "scrcpy.exe --shortcut-mod=lctrl --stay-awake --always-on-top --no-audio --kill-adb-on-close" for USB and WIFI connection.

When I click "x" on terminal with parameters from above I got error scrcpy.exe has stopped working (hang on while Windows reports the problem to Microsoft" and ADB.exe is not closed.

I have removed one by one parameter and noticed that error accrued only when I use "--no-audio" parameter.

When I click "x" on scrcpy, with "--no-audio", there is no error and adb.exe is killed on close.

I have also tried with "--no-audio-playback" but all is the same.

I am updating windows and programs with winget weekly and I have noticed this few days ago.

Hope that this information is helpful for some new scrcpy releases.

scrcpy.exe --shortcut-mod=lctrl --stay-awake --always-on-top --no-audio --kill-adb-on-close scrcpy 2.4 https://github.com/Genymobile/scrcpy

rom1v commented 3 weeks ago

I am updating windows and programs with winget weekly and I have noticed this few days ago.

Please test with the official release (there were issues on the winget package).

When I click "x" on scrcpy

Just to confirm: you're closing the scrcpy window, not the terminal directly?

webinizam commented 3 weeks ago

I am updating windows and programs with winget weekly and I have noticed this few days ago.

Please test with the official release (there were issues on the winget package).

I am using scrcpy from here (scrcpy-win64-v2.4.zip) like portable version.

When I click "x" on scrcpy

Just to confirm: you're closing the scrcpy window, not the terminal directly?

When I close scrpy window there is no error, only when I close terminal while scrcpy is on with parameter --no-audio I get error message.

webinizam commented 3 weeks ago

SCRCPY-with-NO-AUDIO - error when close terminal SCRCPY-with-NO-AUDIO SCRCPY-without-NO-AUDIO - all is ok, no error SCRCPY-without-NO-AUDIO

rom1v commented 3 weeks ago

You should never close the terminal directly, it just kills the app abruptly. For example, if you record (scrcpy --record=file.mp4), your recorded file would be corrupted.

That being said, it should not crash ("has stopped working") the way it does. The problem is that I have no idea how to get a meaningful stacktrace to understand why it crashes.