Open rom1v opened 2 weeks ago
My first comment:
I like the idea. However, Alt is already used to capture/uncapture the mouse when video mirroring is disabled, and Alt+right and Alt+middle clicks are often captured by the window manager (e.g. to resize the window). Ctrl+click and Shift+click are used to simulate several fingers (but only for left click, so Ctrl could be used for additional shortcuts in theory).
So I keep the idea in mind, but for now I don't know how to expose it properly.
One unexpected difficulty is related to the injection of either finger or mouse: c7b1d0e and #3568.
If there is a possibility of secondary click, then we must use a mouse even for left click for consistency. But that prevents multi-fingers to work on some devices (but not all), for example for pinch-to-zoom, rotate and tilt simulation.
The workaround was: use mouse if --forward-all-clicks
(now if there is at least one click forwarded in --mouse-bind=xxxx
), finger otherwise.
But if we add key+click, forwarding secondary clicks will always be possible (either with key pressed or unpressed), so it won't use "finger" by default anymore, breaking the behavior on some devices.
Implemented by #5076.
A feature request posted on reddit: