Geo-Web-Project / browser

An interface that uses geolocation to navigate/resolve content on the Geo Web.

MIT License

3 stars 8 forks source link

feat: use latest contracts, subgraph and Ceramic node #48

Closed tnrdd closed 1 year ago

tnrdd commented 1 year ago

Description

Update the Spatial Browser after changes to lower layers, use new:

registry contract address
subgraph
dedicated Ceramic node URL

Issue

fixes #47

Checklist:

[x] My commit message follows the Conventional Commits specification
[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[x] I have tested my code
[x] My changes generate no new warnings
[x] My PR is rebased off the most recent main or appropriate feature branch
[x] My PR is opened against the main or appropriate feature branch

Additional comments

@codynhat @gravenp

tnrdd commented 1 year ago

Latest push should address the 3D Gallery items not loading and the link. I'm not sure about the Orbis error, does it still happen?

gravenp commented 1 year ago

I'm not sure about the Orbis error, does it still happen?

Yeah, this is still there in the latest build. My strong suspicion is that it's Clay vs Mainnet related. If they don't support a Clay, then we can probably just leave it for now, but make sure it works for mainnet.

codynhat commented 1 year ago

Are we using the latest version of the Orbis module?

gravenp commented 1 year ago

Are we using the latest version of the Orbis module?

It doesn't look like it. We can move to 0.0.43 for the modules (https://www.npmjs.com/package/@orbisclub/modules) and 0.4.3 (non-beta version) for the SDK (https://www.npmjs.com/package/@orbisclub/orbis-sdk)?

tnrdd commented 1 year ago

After the update of @orbisclub/modules and @orbisclub/orbis-sdk I was able to leave a comment on the chat associated with the parcel 👍

gravenp commented 1 year ago

@tnrdd Yup! Orbis chat looks good.

Are you able to reproduce the client-side exception from above? I get it intermittently, but it seems to be an issue with it not having the location to check for (or something else undefined) at the time of the initial content queries.

tnrdd commented 1 year ago

Yes I was able to reproduce, needed to get a parcel on my current location. The issue was that now sometimes Ceramic content would be loaded as an array with an undefined element instead of either just a filled array or the whole thing as null and it was tricking the check we had in place.