search

GeoBosh / Rdpack

R package Rdpack provides functions and macros facilitating writing and management of R documentation.
https://geobosh.github.io/Rdpack/
28 stars 6 forks source link

doi entries should generate https links #20

Closed MLopez-Ibanez closed 3 years ago

MLopez-Ibanez commented 3 years ago

Currently, the URLs generated by Rdpack for doi field are not https. This gives a message in CRAN:

URL: http://doi.org/10.1007/3-540-44719-9_15 (moved to https://doi.org/10.1007/3-540-44719-9_15) From: man/eaf-package.Rd Status: 200 Message: OK

Although this message is harmless, it would be nice to directly generate https links.

GeoBosh commented 3 years ago

Thanks for the report.

Strange, on my side the dois get 'https' rendering. My packages on CRAN also render the doi link as https (e.g., see the reference manual of package mixAR on CRAN). It would help to know if you are using the latest version of Rdpack (and rbibutils) from CRAN, though off-my-head I think that doi rendering is done by R, so that could be the reason if you are using an older R version.

MLopez-Ibanez commented 3 years ago

Very strange. I can see that the links are rendered correctly in HTML here:

https://mlopez-ibanez.github.io/eaf/reference/eaf-package.html

But the CRAN builder complains about the same links in the .Rd files:

https://win-builder.r-project.org/incoming_pretest/eaf_2.0_20210106_172059/Debian/00check.log

Well not a huge concern, but I wonder if I'm doing something wrong to trigger this behavior.

MLopez-Ibanez commented 3 years ago

i can trigger the same errors myself in r-hub: https://builder.r-hub.io/status/eaf_2.0.tar.gz-30839d61b47c4068a9f464fd89e5682e

That is using Rdpack 2.1.

MLopez-Ibanez commented 3 years ago

I also noticed that when I download the package built for Windows: https://artifacts.r-hub.io/eaf_2.0.tar.gz-30839d61b47c4068a9f464fd89e5682e

The URLs for the DOIs are wrong in the generated html pages, for example html/eaf-package.html : doi: <a href="http://doi.org/10.1007/3-540-44719-9_15">10.1007/3-540-44719-9_15</a>.

GeoBosh commented 3 years ago

Which version of R do you build eaf on? Even better, run tools:::Rd_expr_doi and see if the code inserts http or https (in my versions of R it is https). If you give me a link or send me the tarball of eaf, I actually could look at build/partial.rdb.

MLopez-Ibanez commented 3 years ago

I believe this was due to an old version of R. I cannot reproduce it anymore with R 3.6.3. Thanks!