GeoCat / bridge-style

Cartography library making style format conversions as easy as using Python.
MIT License
44 stars 13 forks source link

Add missing QGIS Line Stroke styles #88

Open geraldo opened 3 months ago

geraldo commented 3 months ago

Actually only "Solid Line" Stroke Style for Line Symbols is implemented, but there do exist different options for dashed and dotted lines:

image

I'm going to sumit a PR to add Stroke Styles for missing Dash Line, Dot Line, Dash Dot Line and Dash Dot Dot Line

GeoSander commented 3 months ago

I am a bit amazed that this has never been implemented @geraldo. At first glance, it seems that it sets a default dash array when the line style is not "solid": https://github.com/GeoCat/bridge-style/blob/00cff0ff89166c7f8af6542914d974dd81b9ae88/bridgestyle/qgis/togeostyler.py#L664-L665

Guess that it would be nice if the dash array will be properly set to whatever the pattern is. 👍

geraldo commented 3 months ago

Ok, for now I added the defined line styles as described in the issue. So it would be nice to also Use custom dash pattern like:

image