search

GeoDaCenter / data-and-lab

For CSDS: sample data, data cleaning, labs and miscellaneous
https://geodacenter.github.io/data-and-lab/
0 stars 3 forks source link

Feat: using kepler.gl to replace leaflet map #42

Closed lixun910 closed 9 months ago

lixun910 commented 11 months ago

The target is to prebuild the react component for mapping first and the output will be in asserts/js/webglmap.js

lixun910 commented 11 months ago

@dpeachpeach Hi David, this is the react project to create the bundle.js test_kepler.zip

lixun910 commented 11 months ago

@dpeachpeach See the list of tasks above. Thanks!

  • move the react + webpack code to keplermap/ test_kepler.zip
  • copy and reconfig the webpack.config.js
  • update the js libraries and the package.json

The target is to prebuild the react component for mapping first and the output will be in asserts/js/webglmap.js

  • replace the old leaflet code in each post with the new
  • update the CSS style to match our site
lixun910 commented 11 months ago

@dpeachpeach check out this branch feat-webgl-map, run jekyll serve and you should be able to see the kepler.gl map running in the first AirBnB data page.

dpeachpeach commented 11 months ago

yep! @lixun910 I'm integrating kepler gl into the other markdown files

dpeachpeach commented 11 months ago

Hey @lixun910 I tested everything on my end locally and it works ok. Fixed some styling issues. I couldn't get building to work locally so everything in the map itself style-wise is the same but I'm hoping i can solve that sometime after today. Let me know if everything looks good

lixun910 commented 11 months ago

For conflicting files, you can rebase main branch into your current branch (see instructions here)

lixun910 commented 11 months ago

ref: https://github.com/GeoDaCenter/reactgeoda/pull/36

dpeachpeach commented 11 months ago

Hey @lixun910 , after I resolve the conflict should I merge? Or should I commit the changes I made with integrating react-geoda

lixun910 commented 11 months ago

Hey @lixun910 , after I resolve the conflict should I merge? Or should I commit the changes I made with integrating react-geoda

@dpeachpeach Thanks David! You can solve the conflict first, then you can commit the changes integrating react-geoda. Then, merge the PR after I review it :)