search

GeoDaCenter / geoda

GeoDa: An introduction to spatial data analysis
http://geodacenter.github.io
GNU General Public License v3.0
680 stars 155 forks source link

Fix: use static registry key to check vcredist on x86 Windows installer #2474

Open SpecterShell opened 3 months ago

SpecterShell commented 3 months ago

Currently the x86 Windows installers rely on the registry key of the "Apps and Features" entry to check if the x86 version of VCRedist has been installed. However the registry key differs between each version of VCRedist, making the installer attempt to install VCRedist during installation when a newer version of VCRedist has been installed. This PR replaces the registry key with the static one and has been tested locally.

Related GitHub Actions runs with the fix: https://github.com/SpecterShell/geoda/actions/runs/8322035879

lixun910 commented 3 months ago

Thanks for your PR @SpecterShell ! C