search

GeoDaCenter / geoda

GeoDa: An introduction to spatial data analysis
http://geodacenter.github.io
GNU General Public License v3.0
716 stars 156 forks source link

LOWESS regression crashed on 64-bit windows #292

Closed lixun910 closed 8 years ago

lixun910 commented 8 years ago

The algorithm of LOWESS regression has a bug when use std::partial_sort() function. It's definition is:

template< class RandomIt > void partial_sort( RandomIt first, RandomIt middle, RandomIt last );

The usage in ShapeOperations\Lowess.cpp gives wrong parameters, and cause "invalid iteration" error and a crash.

This error has been ignored on Mac OSX as well as 32-bit windows (no crash on these platforms).

jkoschinsky commented 8 years ago

Verified fix in GeoDa 1.7.87 ( Win 7 Professional (64-bit): No more crash.

Could you confirm that the iterations are active: Nothing changes for different iterations, even in small datasets. If it's active, you can close the ticket.

lixun910 commented 8 years ago

Verified via debug, the iterations are active.