GeoDaCenter / rgeoda

R library for spatial data analysis based on libgeoda and GeoDa
72 stars 14 forks source link

LLVM 19 compilation issue #49

Open lixun910 opened 2 months ago

lixun910 commented 2 months ago

Dear maintainer,

Please see the problems shown on https://cran.r-project.org/web/checks/check_results_rgeoda.html.

Specifically, please see the clang19 additional issues.

These show compilation problems using the compilers from LLVM 19, finally released yesterday. The results are for Fedora 36 (see https://www.stats.ox.ac.uk/pub/bdr/clang19/README.txt) and can conveniently be reproduced using the clang-19 and flang-19 packages in Debian unstable.

Can you please fix "as necessary"?

Please correct before 2024-10-09 to safely retain your package on CRAN.

Best wishes, The CRAN Team

lixun910 commented 2 months ago

It looks like not a bug of rgeoda, but a bug when #include <boost/geometry.hpp> from Boost::geometry. Did some research, and it looks like a known issue of Boost for clang19, https://github.com/llvm/llvm-project/issues/101079, and some fixes are in progress: https://github.com/eddelbuettel/bh/issues/101

The fix has been merged into develop branch in boost::qvm https://github.com/boostorg/qvm/commit/106d411db30d44966d2db5397508d01ce170e17d

However, if -Wno-error=missing-template-arg-list-after-template-kw can be used as a workaround, it would be great that CRAN can accept it as a solution. See CRAN accepts -Wno-error=enum-constexpr-conversion for c++17:

https://cran.r-project.org/doc/manuals/r-devel/R-exts.html

Screenshot 2024-09-23 at 11 18 51 AM