GeoDaCenter / spatial_access

https://spatial.uchicago.edu
37 stars 11 forks source link

ERROR: tsfca #68

Closed ifarah closed 5 years ago

ifarah commented 5 years ago

I tried tsfca with different data and run every time into the same issue. Do you know what's happening @lmnoel?:

Screen Shot 2019-04-29 at 12 15 29 PM
lmnoel commented 5 years ago

Does the same issue occur if you aren't loading the transit matrix from csv?

ifarah commented 5 years ago

It does work with tmx.

ifarah commented 5 years ago

When I don't specify a matrix, I can't specify "disable_area_threshold=True" and the area is too small for it to run (which would be a separate issue in itself.)

lmnoel commented 5 years ago

re: the disable_area_threshold issue, I am moving all transit matrix-related default argument to the Configs class which will be passed down from a Model to BaseModel to p2p

lmnoel commented 5 years ago

could you install the latest version and try again?

ifarah commented 5 years ago

I tried upgrading it, uninstalling/installing and I get this error: Command "/usr/local/opt/python/bin/python3.6 -u -c "import setuptools, tokenize;file='/private/tmp/pip-install-7g15tksc/spatial-access/setup.py';f=getattr(tokenize, 'open', open)(file);code=f.read().replace('\r\n', '\n');f.close();exec(compile(code, file, 'exec'))" install --record /private/tmp/pip-record-c40icfau/install-record.txt --single-version-externally-managed --compile" failed with error code 1 in /private/tmp/pip-install-7g15tksc/spatial-access/

ifarah commented 5 years ago

I don't know if you updated this or if it's a problem with the installation @lmnoel?

lmnoel commented 5 years ago

Sorry, it's definitely a problem on my end! It's been a super busy week and I haven't gotten to it yet, I hope to in the next couple days

lmnoel commented 5 years ago

@ifarah fixed

lmnoel commented 5 years ago

Also, I implemented the extended range option for the transit matrix. See the require_extended_range boolean in Configs

ifarah commented 5 years ago

Would this be the equivalent to disable_area_threshold? Not sure what the difference is between require_extended_range and disable_area_threshold @lmnoel

lmnoel commented 5 years ago

No. disable_area_threshold removes a synthetic limit on the area that a request can cover. require_extended_range increases the maximum impedance of any pair of locations from 65,535 to 4,294,967,295. Does that make more sense?

ifarah commented 5 years ago

Yes, sounds good!

ifarah commented 5 years ago

Could you please increase the default value to 5000 in line 44 of NetworkInterface.py? self.area_threshold = None if disable_area_threshold else 5000

I believe now it's too small