GeoDaCenter / spatial_access

https://spatial.uchicago.edu
37 stars 11 forks source link

Check for disconnected nodes in OD matrix #7

Closed ifarah closed 5 years ago

jkoschinsky commented 5 years ago

Meet with Shiv for overview of his related code updates

On Mon, Oct 1, 2018, 10:19 PM Irene Farah notifications@github.com wrote:

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/GeoDaCenter/spatial_access/issues/7, or mute the thread https://github.com/notifications/unsubscribe-auth/ANC8fw4siSrv1exaSxQBnmF_wg5ItFvQks5ugts2gaJpZM4XDQgV .

lmnoel commented 5 years ago

Looked at the OSM network, and we're already removing all nodes that aren't in any edges. Problem must be only non-leaf node subgraphs.

lixun910 commented 5 years ago

@lmnoel 2cents: For the disconnected nodes, if OSM network removes node that only appears in one edge before analysis, then it might cause a problem to find nearest nodes that connect two subgraphs.

How about find the closest pair of nodes that connect two subgraphs, mark them (don't delete them). Then, let OSM network do the removing job?

lmnoel commented 5 years ago

Good idea. Will investigate.