GeoDaCenter / spatial_access

https://spatial.uchicago.edu
37 stars 11 forks source link

default standarization AccessModel #80

Closed ifarah closed 5 years ago

ifarah commented 5 years ago

Could the default of normalize_type in AccessModel be:

 C=(self.model_results[column]-self.model_results[column].min())
 D=(self.model_results[column].max()-self.model_results[column].min())
 self.model_results[column]=(C/D)*100

instead of the z-score @lmnoel ? I validated the data with WalkScore by standarizing it this way, so I believe it makes better sense than z-score standarization as default.

Thanks!

lmnoel commented 5 years ago

Sure, what do you want to call this method?

On Fri, Jun 7, 2019 at 16:21 Irene Farah notifications@github.com wrote:

Could the default of normalize_type in AccessModel be:

C=(self.model_results[column]-self.model_results[column].min()) D=(self.model_results[column].max()-self.model_results[column].min()) self.model_results[column]=C/D

instead of the z-score @lmnoel https://github.com/lmnoel ? I validated the data with WalkScore by standarizing it this way, so I believe it makes better sense than z-score standarization as default.

Thanks!

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/GeoDaCenter/spatial_access/issues/80?email_source=notifications&email_token=AE533KWJKPOPEHGIVRWXLETPZLGPHA5CNFSM4HV25TUKYY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4GYK4PGQ, or mute the thread https://github.com/notifications/unsubscribe-auth/AE533KX7NH2S5ISXBZKC4PDPZLGPHANCNFSM4HV25TUA .

-- Logan Noel University of Chicago Class of 2019 Economics Major | Computer Science Minor lnoel@uchicago.edu

ifarah commented 5 years ago

minmax would be great

Screen Shot 2019-06-07 at 5 08 12 PM
lmnoel commented 5 years ago

Done

ifarah commented 5 years ago

Thanks!!