Open angela-li opened 4 years ago
I think this is due to a change made by @lixun910 in commit https://github.com/GeoDaCenter/spatial_access/commit/a726b41e2304455dfd0efe2b7101f8da71efb056 on Models.py that prevents the AccessTime/AccessCount function and others from returning model output, which means that there is nothing to "calculate()" on.
@angela-li Just forward the emails (between me and Irene) to you.
@angela-li The two files committed in a726b41 were changed by @ifarah , and I just helped to push the changes into GeoDaCenter/spatial_access repo. I'd suggest you can just go and change the code to make it work:)
Thanks! While we should probably make sure the unit tests work (#90), I'm not sure this has to do with the a726b41 change, because the version on PyPI should be version 1.0.0 (released in June 2019) and shouldn't take into account any of these commits.
So now I'm rethinking that it has something to do with my _p2pExtension again that affects this line in the Models.py code: https://github.com/GeoDaCenter/spatial_access/blob/a726b41e2304455dfd0efe2b7101f8da71efb056/spatial_access/Models.py#L316
@angela-li I think spatial_access PyPi verion 1.0.0 does NOT contain the change of a726b41.
Yes, that's what I meant :) so I think it's something else internally that's not causing this to work.
@vidal-anguiano is this the same problem that you're running into? I can't get AccessTime or AccessCount to work either; would love if you wanted to take a look into the internals and figure out what's up!
@angela-li , yep, this is the exact problem I am running into as well! I'm looking into it right now, will let you know if I can figure it out.
When running
accessT.calculate()
in the demo notebook I get the following IndexError and cannot continue further: