[Bug]: Spoiler arming keybind requires SHIFT, ALT or CTRL

GeoFS-Extensions / autoland

Accessible plugins for GeoFS, an online flight simulator.

https://geofsautoland.wixsite.com/autoland

GNU General Public License v3.0

6 stars 2 forks source link

[Bug]: Spoiler arming keybind requires SHIFT, ALT or CTRL #127

Closed Guy-Adler closed 2 years ago

Guy-Adler commented 2 years ago

Is there an existing issue for this?

[X] I have searched the existing issues

Description

When not using SHIFT, ALT or CTRL in a keybind set by keyboard mapping, spoilers arming does not work.

Expected behavior

Spoilers arming should work even with a keycode only keybind.

Actual behavior

Spoilers arming only works when using a keybind including SHIFT, ALT or CTRL.

Operating System

Windows 10 21H1

Browser

Chrome 95.0.4638.54 Edge 95.0.1020.40

Version

3.3.0

Guy-Adler commented 2 years ago

This is caused by spoilers_arming/source/chabgeControls.ts:53-61. We should compare the event code to Airbrake toggle (on/off) instead of Spoilers Arming. While doing so, we might as well compare the rest of the meta keys to the keybind, to make it so changing the spoilers toggle key doesn't break stuff.